Driver registry #124
Merged
Driver registry #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
force-pushed
the
b-34-56-58-59-60-83-conn-2
branch
from
1163852
to
ea52aac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 85.87% 86.28% +0.41%
==========================================
Files 107 107
Lines 3639 3712 +73
==========================================
+ Hits 3125 3203 +78
+ Misses 514 509 -5 ☔ View full report in Codecov by Sentry. |
krlmlr
force-pushed
the
b-34-56-58-59-60-83-conn-2
branch
7 times, most recently
from
6bcb2e8
to
27c6c4c
Compare
krlmlr
force-pushed
the
b-34-56-58-59-60-83-conn-2
branch
from
27c6c4c
to
472f1ef
Compare
krlmlr
force-pushed
the
b-34-56-58-59-60-83-conn-2
branch
2 times, most recently
from
a382541
to
7544711
Compare
krlmlr
force-pushed
the
b-34-56-58-59-60-83-conn-2
branch
from
7544711
to
81bdeb6
Compare
This was referenced Mar 24, 2024
|
Merging now to get binaries from r-universe. Highly appreciate your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does many things:
std::unordered_map<>in C++; before commit "Store config with driver object"duckdb()indbConnect(), and vice versa (before commit "path_normalize")With this change, each database file is opened only once, by the call to
duckdb(). The database file is closed when the last connection is closed correctly withdbDisconnect(), or when it is garbage-collected (with a warning). The connection still must be closed withdbDisconnect(), but theshutdownargument that was necessary before is now meaningless.Check consistency of config and readonly objects